Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use asyncio.gather instead of TaskGroup to avoid consumer crashes #8

Merged
merged 4 commits into from
May 21, 2024

Conversation

TheByronHimes
Copy link
Member

There was a problem trying to run both event consumers simultaneously with the TaskGroup approach in asyncio. I reverted to the trusted .gather() style and it works now.

@coveralls
Copy link

coveralls commented May 21, 2024

Pull Request Test Coverage Report for Build 9177617315

Details

  • 0 of 2 (0.0%) changed or added relevant lines in 1 file are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+1.0%) to 88.955%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/nos/main.py 0 2 0.0%
Files with Coverage Reduction New Missed Lines %
src/nos/main.py 1 0.0%
Totals Coverage Status
Change from base Build 9097003186: 1.0%
Covered Lines: 298
Relevant Lines: 335

💛 - Coveralls

@TheByronHimes TheByronHimes merged commit 87215f0 into main May 21, 2024
8 checks passed
@TheByronHimes TheByronHimes deleted the debug_kafka_crash branch May 21, 2024 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants