Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing f-string #9

Merged
merged 5 commits into from
Jun 18, 2024
Merged

Fix missing f-string #9

merged 5 commits into from
Jun 18, 2024

Conversation

lkuchenb
Copy link
Member

No description provided.

@coveralls
Copy link

coveralls commented Jun 17, 2024

Pull Request Test Coverage Report for Build 9548329175

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 88.955%

Totals Coverage Status
Change from base Build 9178293084: 0.0%
Covered Lines: 298
Relevant Lines: 335

💛 - Coveralls

@Cito
Copy link
Member

Cito commented Jun 17, 2024

@Byron Maybe the logging tests should be more specific and not just use the %s pattern.

Copy link
Member

@TheByronHimes TheByronHimes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The tests that should have caught that were written poorly (my fault) and should be fixed with this PR.
Here and here

@lkuchenb
Copy link
Member Author

@TheByronHimes Fixed the test and another issue yielded by the fixed tests. Good to go for another round I guess.

@coveralls
Copy link

coveralls commented Jun 17, 2024

Pull Request Test Coverage Report for Build 9553127099

Details

  • 3 of 3 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.03%) to 88.988%

Totals Coverage Status
Change from base Build 9178293084: 0.03%
Covered Lines: 299
Relevant Lines: 336

💛 - Coveralls

Copy link
Member

@TheByronHimes TheByronHimes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you!

@lkuchenb lkuchenb merged commit dc587b8 into main Jun 18, 2024
8 checks passed
@lkuchenb lkuchenb deleted the fix/f-string branch June 18, 2024 08:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants