setup automatic tests #151
Conversation
.github/workflows/python-test.yml
Outdated
|
|
||
| - name: Install dependencies | ||
| run: | | ||
| sudo apt-add-repository ppa:ubuntugis/ubuntugis-unstable |
There was a problem hiding this comment.
Do we want to always test against unstable? It sounds like this would be better tested in a matrix configuration. https://docs.github.com/en/actions/using-jobs/using-a-matrix-for-your-jobs
There was a problem hiding this comment.
This step is not actually selecting the OS version, but rather installing the necessary system binaries for GDAL, which is required for some Python GIS libraries. But when you pointed this out I noticed that it would indeed be better to use the stable ppa, so I updated it.
I think that it is not necessary to test on different OS versions, since this library mostly does just handle a lot of REST requests. However, I liked the idea of using a strategy matrix to test against different Python verisons, so I made it do that.
Thoughts? Counterpoints?
There was a problem hiding this comment.
@iboates Please excuse the delay, I've been out of the office for the last week!
I agree with you on the OS point; Unless we're testing things that are platform-dependent, we don't really need to test different OSes. Typically, if a package claims to support a Python version, we should be testing said version via a matrix to be sure it's supported (sometimes dependencies drop the lowest version without any announcement, etc.). Changes here look good to me!
.idea/.gitignore
Outdated
There was a problem hiding this comment.
The .idea folder should be added to the .gitignore
There was a problem hiding this comment.
Done, not sure why it happened now and not with all my other commits
|
Thanks for the PR @iboates and for the review @Zeitsperre! |
Co-authored-by: Trevor James Smith <10819524+Zeitsperre@users.noreply.github.com>
…rent python versions
Co-authored-by: Trevor James Smith <10819524+Zeitsperre@users.noreply.github.com>
|
Is it okay to merge now, or are you still modifying something? |
Ok to merge |
|
Hi @iboates & @Zeitsperre, I have invited you both for this repository maintainer. Please accept my invitation. Thank you very much for all of your efforts and contributions to this package. It is a lot more enhanced than before. |
I have set up a Github action pipeline to run tests for every push & PR to master, as well as once a day.
I have disabled a lot of tests because they seem to be using other, less popular testing frameworks, or are dependent on local data.
I am interested in building out more tests to cover individual functionalities more comprehensively, and to use it as a springboard to make more comprehensive coverage of the geoserver API.
Do you have any objections to me removing or otherwise heavily modifying the existing tests?
by the way, I tried to write a pipeline to work on Windows as well, but I really had no idea what I was doing. I couldn't use docker containers, and I was making progress on installing things manually, but ultimately I decided it's not worth the effort. Maybe someone else can add Windows support in the future. My work is still there, just commented out.