Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add in combinatorial code #68

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

Add in combinatorial code #68

wants to merge 7 commits into from

Conversation

dkhofer
Copy link
Collaborator

@dkhofer dkhofer commented Oct 8, 2024

No description provided.

@@ -483,6 +467,30 @@ impl Edge {

(graph, edges_by_node_pair)
}

pub fn boundary_edges_from_sequences(
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't like returning two separate things from the above method, felt like splitting out the boundary edge computation into a separate method


let mut parts_reader = fasta::io::reader::Builder.build_from_path(parts_file_path)?;

let path = Path::get_paths(
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Currently assumes there is only one path with the input name in the db, need to think about how to better handle this. I don't want users to have to specify a block group ID

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could do a blockgroup name + path instead of id. BG would be something like "X-vector", path would be backbone or something

new_edges.insert(edge);
}

for part1 in &parts1 {
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Creates all the edges for the combinatorial design unconditionally. Can add in a flag to just add the specified part orderings if Bob wants

BlockGroupEdge::bulk_create(conn, path.block_group_id, &new_edge_ids);

let path_changes_count = parts1.len() * parts2.len();
let summary_str = format!("{path_name}: {path_changes_count} changes.\n");
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure exactly what to put here, I'm open to suggestions

@dkhofer dkhofer requested a review from Chris7 October 10, 2024 18:02
path_name: Option<String>,
/// The start coordinate for the region to add the library to
#[arg(short, long)]
start: Option<i64>,
Copy link
Collaborator

@bobvh bobvh Oct 10, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

VCF imports fail now on a collision between -s for sample and -s for start

thread 'main' panicked at /Users/bvh/.cargo/registry/src/index.crates.io-6f17d22bba15001f/clap_builder-4.5.17/src/builder/debug_asserts.rs:112:17: Command update: Short option names must be unique for each argument, but '-s' is in use by both 'sample' and 'start'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants