Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Creating Forms 📜 As a Mode Of Input 👨‍💻 #7

Merged
merged 5 commits into from
Sep 2, 2023

Conversation

gisachris
Copy link
Owner

IN This PR I present Creating Forms 📜 As a Mode Of Input 👨‍💻 :

Below are some of my implementations as well as going over the project requirements 🤝 .

Requirements

  • All linters 🔍 should pass.
  • Use GitFlow 🌊.
  • Create a method called current_user 👤 in your ApplicationController 🎮 to make current user data available to all controllers.
  • Create forms to perform creating a Post 📸 on behalf of the current_user👩.
  • Create forms to perform creating a comment 🗯️ on behalf of the current_user 👨.
  • Allow Users 👤 to add likes 👍 to Posts 📸.

Achievements

  • Setup ruby workflow and linters 🔍. ✅
  • use GitFlow 🌊.✅
  • Create a method called current_user 👤 in your ApplicationController 🎮 to make current user data available to all controllers.✅
  • Create forms to perform creating a Post 📸 on behalf of the current_user👩.✅
  • Create forms to perform creating a comment 🗯️ on behalf of the current_user 👨.✅
  • Allow Users 👤 to add likes 👍 to Posts 📸.✅

Conclusion

I look forward to hearing 👂 from you The CR in terms of what can be better implemented 👨‍💻 for the project.

Thankyou!. 🙇

Copy link

@victorokoroji victorokoroji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @gisachris,

✔️ Status: APPROVED 🏆 🎉 🎊

You have done a great job on this project, keep it up 👍 🥇. Your project is complete! There is nothing else to say other than... it's time to merge it :shipit:
congratulations! 🎉💯🌟

Top highlight 🎯

  • Controller actions properly created ✅
  • App works as expected✅
  • Linters are working properly ✅

Optional suggestions

Every comment with the [OPTIONAL] prefix won't stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better. Some of them were simply missed by the previous reviewer and addressing them will really improve your application.

Cheers and Happy coding!👏👏👏

Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.


As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.

@gisachris gisachris merged commit 5cfded6 into development Sep 2, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants