Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[New cygwin version] cygwin-3.5.0 #4787

Closed
github-actions bot opened this issue Feb 1, 2024 · 5 comments
Closed

[New cygwin version] cygwin-3.5.0 #4787

github-actions bot opened this issue Feb 1, 2024 · 5 comments
Assignees

Comments

@github-actions
Copy link

github-actions bot commented Feb 1, 2024

Cygwin 3.5.0 release

https://github.com/cygwin/cygwin/releases/tag/cygwin-3.5.0

@dscho dscho self-assigned this Feb 1, 2024
@dscho
Copy link
Member

dscho commented Feb 1, 2024

I started with the MSYS2 runtime rebase here: msys2/msys2-runtime#194

@rimrul
Copy link
Member

rimrul commented Feb 1, 2024

Just to be clear: The plan is to integrate this after Git for Windows 2.44.0, right?

@dscho
Copy link
Member

dscho commented Feb 11, 2024

Just to be clear: The plan is to integrate this after Git for Windows 2.44.0, right?

Yes. This is my current thinking:

I was considering to upgrade MSYS2 runtime to v3.5.0 in time for Git for Windows v2.44.0, even if it was just released end of January. But I've decided not to rush this, for at least the following reasons:

  • This upgrade has huge implications: Windows 7/8 support will be dropped.
  • I immediately hit a bug in that Cygwin version, where calling (non-Cygwin/MSYS) git.exe from the MSYS2 Bash would always report success, even if the exit code of the git.exe process was non-zero.
  • Cygwin v3.5.0 has been out for less than two weeks, and given the already-found bug, it seems prudent to give it much more time to show (and resolve) bugs.
  • There is still this vexing MSYS2 runtime hang in our Windows/ARM64 pipeline, it happens even with MSYS2 runtime v3.5.0.

@dscho
Copy link
Member

dscho commented Feb 14, 2024

I backported a couple of the console-related fixes from v3.5.0 to v3.4.10: git-for-windows/MSYS2-packages#158. My plan is to deploy and merge that PR before releasing Git for Windows v2.44.0-rc1.

@rimrul
Copy link
Member

rimrul commented Feb 27, 2024

Superseded by #4838

@rimrul rimrul closed this as not planned Won't fix, can't repro, duplicate, stale Feb 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants