Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixup! scalar: enable path-walk during push via config #5220

Merged
merged 1 commit into from
Oct 21, 2024

Conversation

dscho
Copy link
Member

@dscho dscho commented Oct 21, 2024

There was a typo in the configuration Scalar registers, which was missed by author and reviewer 🤦. No big harm done, let's just fix this in time for the next Git for Windows version.

There was a typo in the configuration Scalar registers, which was missed
by author and reviewer 🤦. No big harm done, let's just fix this in time
for the next Git for Windows version.

Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
Copy link

@derrickstolee derrickstolee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this!

@dscho dscho added this to the Next release milestone Oct 21, 2024
derrickstolee added a commit to microsoft/git that referenced this pull request Oct 21, 2024
There was a typo in the configuration Scalar registers, which was missed
by author and reviewer 🤦. No big harm done, let's just fix this in time
for the next Git for Windows version.

This is a companion to git-for-windows#5220.
@dscho dscho merged commit 6b6f8e4 into git-for-windows:main Oct 21, 2024
45 checks passed
@dscho dscho deleted the fix-typo-in-scalar-config branch October 21, 2024 23:09
@dscho
Copy link
Member Author

dscho commented Oct 22, 2024

/add relnote bug As of Git for Windows v2.47.0 was supposed to enable an optimized push algorithm, but for a typo didn't, which was fixed.

The workflow run was started

github-actions bot pushed a commit to git-for-windows/build-extra that referenced this pull request Oct 22, 2024
As of Git for Windows v2.47.0 was supposed to enable [an optimized push
algorithm](git-for-windows/git#5171), but for a
typo didn't, which [was
fixed](git-for-windows/git#5220).

Signed-off-by: gitforwindowshelper[bot] <gitforwindowshelper-bot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants