Rust: Canonical paths for blanket implementations - #22405
Merged
Conversation
hvitved
force-pushed
the
rust/canonical-path-blanket
branch
2 times, most recently
from
August 24, 2026 08:04
a2744e1 to
15eda88
Compare
hvitved
force-pushed
the
rust/canonical-path-blanket
branch
from
August 24, 2026 08:05
15eda88 to
b12b1d0
Compare
hvitved
marked this pull request as ready for review
August 24, 2026 11:15
Contributor
There was a problem hiding this comment.
Pull request overview
Adds canonical Rust paths for blanket trait implementations, enabling models-as-data matching.
Changes:
- Generates
<_ as Trait>canonical paths. - Adds extractor and data-flow coverage.
- Updates expected test outputs.
Show a summary per file
| File | Description |
|---|---|
rust/ql/lib/codeql/rust/internal/PathResolution.qll |
Implements blanket-implementation paths. |
rust/ql/test/extractor-tests/canonical_path/canonical_paths.expected |
Records expected canonical paths. |
rust/ql/test/library-tests/dataflow/models/main.rs |
Adds blanket-model test cases. |
rust/ql/test/library-tests/dataflow/models/external_file.rs |
Adds an inherited trait-model fixture. |
rust/ql/test/library-tests/dataflow/models/models.ext.yml |
Defines explicit model paths. |
rust/ql/test/library-tests/dataflow/models/models.expected |
Records expected data-flow results. |
Review details
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
- Files reviewed: 6/6 changed files
- Comments generated: 0
- Review effort level: Balanced
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements
getCanonicalPathalso for blanket implementations: