Fix a RecursionError that occurs with deeply-nested request bodies - #1423
Open
kurtmckee wants to merge 2 commits into
Open
Fix a RecursionError that occurs with deeply-nested request bodies#1423kurtmckee wants to merge 2 commits into
RecursionError that occurs with deeply-nested request bodies#1423kurtmckee wants to merge 2 commits into
Conversation
kurtmckee
requested review from
MaxTueckeGlobus,
aaschaer,
ada-globus,
derek-globus,
m1yag1 and
sirosen
as code owners
August 31, 2026 21:03
kurtmckee
force-pushed
the
fix-recursion-errors
branch
from
August 31, 2026 21:21
c3fdd5c to
a664337
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
This issue was discovered while testing a service release.
The first commit, which introduces a test that demonstrates the problem, takes over 7 seconds locally to eventually throw
RecursionError.The second commit, which eliminates recursion entirely, makes the test succeed in 0.04 seconds.
Fixed
RecursionErrorthat occurs with deeply-nested request bodies.