test(p/uint25): Increase Test Coverage for uint256 Package
#2931
+757
−280
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
notJoon
requested review from
jaekwon and
petar-dambovaliev
and removed request for
a team
github-actions
bot
added
the
🧾 package/realm
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2931 +/- ##
==========================================
+ Coverage 60.90% 60.95% +0.05%
==========================================
Files 564 564
Lines 75273 75273
==========================================
+ Hits 45846 45885 +39
+ Misses 26055 26018 -37
+ Partials 3372 3370 -2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
jefft0
reviewed
Oct 10, 2024
| @@ -142,7 +142,8 @@ func (z *Uint) fromDecimal(bs string) error { | |||
| for i, mult := range multipliers { | |||
| if remaining <= 0 { | |||
| return nil // Done | |||
| } else if remaining > 19 { | |||
| } | |||
| if remaining > 19 { | |||
There was a problem hiding this comment.
Was this change requested by lint?
There was a problem hiding this comment.
This was just my personal preference. should I revert?
There was a problem hiding this comment.
I think so. My guess is that core devs will approve the PR more quickly if it just updates the tests. It's up to you.
There was a problem hiding this comment.
good. reverted just in case
jefft0
added
the
review team
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Increased the test coverage of the
p/demo/uint256package. Previously, only about 40% was covered, but now it has increased to 90% (checked in go).The existing implementations of uint256 functions have not been modified.
related with: #2846
BREAKING CHANGE: xxxmessage was included in the description