Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: typo: as = as instead of as = av #2936

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

MalekLahbib
Copy link
Contributor

Contributors' checklist...
  • Added new tests, or not needed, or not feasible
  • Provided an example (e.g. screenshot) to aid review or the PR is self-explanatory
  • Updated the official documentation or not needed
  • No breaking changes were made, or a BREAKING CHANGE: xxx message was included in the description
  • Added references to related issues and PRs
  • Provided any useful hints for running manual tests
  • Added new benchmarks to generated graphs, if any. More info here.

@MalekLahbib MalekLahbib requested review from a team as code owners October 10, 2024 15:16
@MalekLahbib MalekLahbib requested review from n2p5 and zivkovicmilos and removed request for a team October 10, 2024 15:16
@github-actions github-actions bot added the 🧾 package/realm Tag used for new Realms or Packages. label Oct 10, 2024
Copy link

codecov bot commented Oct 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 60.95%. Comparing base (8a62a28) to head (6ab4577).
Report is 5 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2936      +/-   ##
==========================================
- Coverage   60.95%   60.95%   -0.01%     
==========================================
  Files         564      564              
  Lines       75273    75273              
==========================================
- Hits        45884    45883       -1     
- Misses      26019    26021       +2     
+ Partials     3370     3369       -1     
Flag Coverage Δ
contribs/gnodev 60.65% <ø> (-0.82%) ⬇️
contribs/gnofaucet 14.46% <ø> (ø)
gno.land 67.92% <ø> (ø)
gnovm 65.78% <ø> (+<0.01%) ⬆️
misc/genstd 80.54% <ø> (ø)
misc/logos 19.88% <ø> (ø)
tm2 62.08% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@notJoon
Copy link
Member

notJoon commented Oct 11, 2024

It looks fine. It seems you've made modifications because it was always outputting as an unsupported type message. Could you please change the title more clearly and add the descriptions what the problem was?

@MalekLahbib
Copy link
Contributor Author

It looks fine. It seems you've made modifications because it was always outputting as an unsupported type message. Could you please change the title more clearly and add the descriptions what the problem was?

I was looking to understand uassert package and saw this warning from gnopls:

Screenshot 2024-10-11 at 09 00 12

I think the function would work correctly but there's still an error on that line.

@jefft0 jefft0 added the review team PRs that should be reviewed first by the review team or external contributors label Oct 11, 2024
Copy link
Contributor

@mvertes mvertes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🧾 package/realm Tag used for new Realms or Packages. review team PRs that should be reviewed first by the review team or external contributors
Projects
Status: In Progress
Status: Triage
Development

Successfully merging this pull request may close these issues.

4 participants