Prevent RandReader.Read argument from escaping to the heap #202
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qmuntal
requested review from
ueno,
karianna,
derekparker,
dagood,
mertakman and
gdams
dagood
approved these changes
Oct 8, 2024
Co-authored-by: Davis Goodin <dagood@users.noreply.github.com>
mertakman
approved these changes
Oct 10, 2024
dagood
approved these changes
Oct 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Go 1.24 will bring back
noescapeandnocallbackcgo directives, this time without the issue that made us revert the previous attempt to use them (see #129).For now just use the cgo directives for
go_openssl_RAND_bytes, as there is no other way to avoid the allocation.