Skip to content
This repository has been archived by the owner on Jan 16, 2021. It is now read-only.

Allow username in package name #586

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

hrathod-twitch
Copy link

#585

Don't fail if a vanity service returns
a package name with a SSH url and a
username, such as ssh://git@example.com/org/package.

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

Don't fail if a vanity service returns
a package name with a SSH url and a
username, such as ssh://git@example.com/org/package.
@googlebot
Copy link

CLAs look good, thanks!

@googlebot googlebot added cla: yes and removed cla: no labels Oct 9, 2018
@gopherbot
Copy link

This PR (HEAD: 5677755) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/gddo/+/140719 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link

Message from Gerrit User 5976:

Patch Set 1:

Congratulations on opening your first change. Thank you for your contribution!

Next steps:
Within the next week or so, a maintainer will review your change and provide
feedback. See https://golang.org/doc/contribute.html#review for more info and
tips to get your patch through code review.

Most changes in the Go project go through a few rounds of revision. This can be
surprising to people new to the project. The careful, iterative review process
is our way of helping mentor contributors and ensuring that their contributions
have a lasting impact.

During May-July and Nov-Jan the Go project is in a code freeze, during which
little code gets reviewed or merged. If a reviewer responds with a comment like
R=go1.11, it means that this CL will be reviewed as part of the next development
cycle. See https://golang.org/s/release for more details.


Please don’t reply on this GitHub thread. Visit golang.org/cl/140719.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link

Message from Katie Hockman:

Patch Set 2: Commit message was updated.


Please don’t reply on this GitHub thread. Visit golang.org/cl/140719.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link

Message from Katie Hockman:

Patch Set 3: Commit message was updated.


Please don’t reply on this GitHub thread. Visit golang.org/cl/140719.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link

Message from Katie Hockman:

Patch Set 4:

Please update the format of the commit message to meet the contribution guidelines (https://golang.org/doc/contribute.html#commit_messages).

I am adding the wait-issue hashtag until a decision has been made on the linked issue.


Please don’t reply on this GitHub thread. Visit golang.org/cl/140719.
After addressing review feedback, remember to publish your drafts!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants