-
Notifications
You must be signed in to change notification settings - Fork 265
Allow username in package name #586
base: master
Are you sure you want to change the base?
Conversation
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here (e.g. What to do if you already signed the CLAIndividual signers
Corporate signers
|
Don't fail if a vanity service returns a package name with a SSH url and a username, such as ssh://git@example.com/org/package.
CLAs look good, thanks! |
This PR (HEAD: 5677755) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/c/gddo/+/140719 to see it. Tip: You can toggle comments from me using the |
Message from Gerrit User 5976: Patch Set 1: Congratulations on opening your first change. Thank you for your contribution! Next steps: Most changes in the Go project go through a few rounds of revision. This can be During May-July and Nov-Jan the Go project is in a code freeze, during which Please don’t reply on this GitHub thread. Visit golang.org/cl/140719. |
Message from Katie Hockman: Patch Set 2: Commit message was updated. Please don’t reply on this GitHub thread. Visit golang.org/cl/140719. |
Message from Katie Hockman: Patch Set 3: Commit message was updated. Please don’t reply on this GitHub thread. Visit golang.org/cl/140719. |
Message from Katie Hockman: Patch Set 4: Please update the format of the commit message to meet the contribution guidelines (https://golang.org/doc/contribute.html#commit_messages). I am adding the wait-issue hashtag until a decision has been made on the linked issue. Please don’t reply on this GitHub thread. Visit golang.org/cl/140719. |
#585
Don't fail if a vanity service returns
a package name with a SSH url and a
username, such as ssh://git@example.com/org/package.