Add Adan optimizer. #1090
Open
Add Adan optimizer. #1090
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
fabianp
reviewed
Oct 4, 2024
fabianp
reviewed
Oct 4, 2024
fabianp
reviewed
Oct 4, 2024
fabianp
reviewed
Oct 4, 2024
fabianp
reviewed
Oct 4, 2024
|
thanks for the contribution @carlosgmartin ! Left some minor documentation nitpicks in there |
carlosgmartin
force-pushed
the
adan
branch
2 times, most recently
from
537bc1f
to
e7480c4
Compare
|
@fabianp Done. |
|
looks good to me. just one last thing. could you please paste here a screenshot (or two, if it doesn't fit) of the rendering of the adan optimizer's docstring in the webpage? thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Picking up #410.