Skip to content

Commit

Permalink
Revert back to Node 16 for v1 series (#356)
Browse files Browse the repository at this point in the history
  • Loading branch information
sethvargo authored Nov 29, 2023
1 parent f105ef0 commit cf2a975
Show file tree
Hide file tree
Showing 3 changed files with 9 additions and 10 deletions.
10 changes: 6 additions & 4 deletions .github/workflows/test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -18,9 +18,11 @@ on:
push:
branches:
- 'main'
- 'release/**/*'
pull_request:
branches:
- 'main'
- 'release/**/*'
workflow_dispatch:

concurrency:
Expand All @@ -37,7 +39,7 @@ jobs:

- uses: 'actions/setup-node@v4'
with:
node-version: '20.x'
node-version: '16.x'

- name: 'npm build'
run: 'npm ci && npm run build'
Expand Down Expand Up @@ -65,7 +67,7 @@ jobs:

- uses: 'actions/setup-node@v4'
with:
node-version: '20.x'
node-version: '16.x'

- name: 'npm build'
run: 'npm ci && npm run build'
Expand Down Expand Up @@ -141,7 +143,7 @@ jobs:

- uses: 'actions/setup-node@v4'
with:
node-version: '20.x'
node-version: '16.x'

- name: 'npm build'
run: 'npm ci && npm run build'
Expand Down Expand Up @@ -216,7 +218,7 @@ jobs:

- uses: 'actions/setup-node@v4'
with:
node-version: '20.x'
node-version: '16.x'

- name: 'npm build'
run: 'npm ci && npm run build'
Expand Down
2 changes: 1 addition & 1 deletion action.yml
Original file line number Diff line number Diff line change
Expand Up @@ -186,6 +186,6 @@ branding:
color: 'blue'

runs:
using: 'node20'
using: 'node16'
main: 'dist/main/index.js'
post: 'dist/post/index.js'
7 changes: 2 additions & 5 deletions bin/runTests.sh
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
#!/usr/bin/env bash
set -eEuo pipefail
set -eEuxo pipefail

#
# As of Node 20, the --test parameter does not support globbing, and it does not
Expand All @@ -13,7 +13,4 @@ set -eEuo pipefail
# fed to the caller.
#

FILES="$(node -e "process.stdout.write(require('node:fs').readdirSync('./', { recursive: true }).filter((e) => {return e.endsWith('.test.ts') && !e.startsWith('node_modules');}).sort().join(' '));")"

set -x
exec node --require ts-node/register --test-reporter spec --test ${FILES}
exec node --require ts-node/register --test ./tests/client/credentials_json_client.test.ts ./tests/client/workload_identity_client.test.ts ./tests/utils.test.ts

0 comments on commit cf2a975

Please sign in to comment.