Support viewForRow in grey_pickerColumnSetToValue matcher #1810
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Matcher
grey_pickerColumnSetToValue
works fine for UIPicker with delegate that implementspickerView:titleForRow:forComponent
ORpickerView:attributedTitleForRow:forComponent
but currently does not work for
pickerView:viewForRow:forComponent:reusingView:
I believe it should work with viewForRow, because GREYPickerAction works fine with it and there even test that checks it –
PickerViewInteractionTest.testViewForRowDefined
.Unfortunately, I think that this test is broken: corresponding
PickerViewController
implements both delegate methods –pickerView:titleForRow:forComponent
ANDpickerView:viewForRow:forComponent:reusingView:
, that why test pass.So, I added support for viewForRow in
grey_pickerColumnSetToValue
matcher, its just copy-paste fromGREYPickerAction
and updated test code.