[Network] Resolve Xcode 15 Beta 4 runtime warning #114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ncooke3
commented
Jul 14, 2023
ncooke3
commented
Jul 18, 2023
paulb777
reviewed
Jul 18, 2023
paulb777
approved these changes
Jul 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
See firebase/firebase-ios-sdk#11536 for details. Xcode 15 Beta 3 introduces a runtime warning when creating an upload task from a URL request that contains a non-nil HTTPBody field. I can't find any reasoning as to why this is now a warnings, but it looks like URL request objects should only contain metadata about the request, not the data itself.
Fix firebase/firebase-ios-sdk#11536
After merging, will open a new PR with a changelog update and podspec bump. We can do a CocoaPods + SPM release for this. This will align the two, since we have done some SPM-only releases in the time since the last CocoaPods release.
cc: @htcgh, @pcfba