-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[v8] Merge release branch into main
#198
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
ncooke3
commented
Jul 8, 2024
* [Cleanup] Remove '+ [GULAppEnvironmentUtil isIOS7OrHigher]' API * Remove accidental newline
* Use guaranteed const for associated object key * add changelog
* [v8] Add nullabilty annotations to public headers * Fix CI * Add another nullable attribute * update impl * update impl 2 * style
* [Infra] Disable NSURLSession+GULPromisesTests.m for Catalyst (#167) * [Docs] Update README.md to recommend using `--use-json` (#178) * [Cleanup] Resolve low-hanging TODOs and cleanup outdated code (#81) * Resolve Package.swift TODO * Various cleanup * Style Package.swift * Revert to current [GULAppEnvironmentUtil systemVersion] implementation * Use main's Package.swift * Apply suggestions from code review * Update GoogleUtilities/AppDelegateSwizzler/Public/GoogleUtilities/GULSceneDelegateSwizzler.h * Update GoogleUtilities/Environment/GULAppEnvironmentUtil.m * Update GoogleUtilities/Network/Public/GoogleUtilities/GULNetworkURLSession.h * Style * Fix test * fix var name: * fix var name again
* [v8] Replace read keychain API with completion handler based API (#182) * [v8] Replace write keychain API with completion handler based API (#183) * [v8] Replace remove keychain API with completion handler based API (#184) * [v8] Replace remove keychain API with completion handler based API * Update GoogleUtilities/Environment/SecureStorage/GULKeychainStorage.m * [v8] Fix tests, docs, and imports following `GULKeychainStorage` API changes (#185) * [v8] Remove Promises API and dependency specifications (#186) * [v8] Remove Promises API and dependency specifications * Remove other header * [v8] Add changelog for removal of Promises dependency * [v8] Remove extraneous parameter from removeObject API (#188)
Going to do again with updated local |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.