Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Promises dependency in SPM #200

Merged
merged 1 commit into from
Jul 10, 2024
Merged

Remove Promises dependency in SPM #200

merged 1 commit into from
Jul 10, 2024

Conversation

andrewheard
Copy link
Collaborator

The dependency on https://github.com/google/promises is no longer needed.

@andrewheard andrewheard requested a review from ncooke3 July 10, 2024 22:03
@google-oss-bot
Copy link

Coverage Report 1

Affected Products

No changes between base commit (e70da7c) and merge commit (c80b33d).

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/IJi68ZhCBG.html

paulb777
paulb777 approved these changes Jul 10, 2024
View reviewed changes
Copy link
Member

@paulb777 paulb777 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

@andrewheard andrewheard merged commit 41bf68b into main Jul 10, 2024
21 checks passed
@andrewheard andrewheard deleted the ah/remove-promises-dep branch July 10, 2024 23:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paulb777 paulb777 paulb777 approved these changes

@ncooke3 ncooke3 Awaiting requested review from ncooke3

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@andrewheard @google-oss-bot @paulb777