Remove deprecated logger APIs and update Changelog #202
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Coverage Report 1Affected Products
Test Logs |
ncooke3
approved these changes
Jul 11, 2024
andrewheard
reviewed
Jul 11, 2024
Comment on lines
-151
to
-163
| NS_FORMAT_FUNCTION(4, 5) DEPRECATED_MSG_ATTRIBUTE("Replaced by `GULOSLogError`."); | ||
| extern void GULLogWarning( | ||
| GULLoggerService service, BOOL force, NSString *messageCode, NSString *message, ...) | ||
| NS_FORMAT_FUNCTION(4, 5) DEPRECATED_MSG_ATTRIBUTE("Replaced by `GULOSLogWarning`."); | ||
| extern void GULLogNotice( | ||
| GULLoggerService service, BOOL force, NSString *messageCode, NSString *message, ...) | ||
| NS_FORMAT_FUNCTION(4, 5) DEPRECATED_MSG_ATTRIBUTE("Replaced by `GULOSLogInfo`."); | ||
| extern void GULLogInfo( | ||
| GULLoggerService service, BOOL force, NSString *messageCode, NSString *message, ...) | ||
| NS_FORMAT_FUNCTION(4, 5) DEPRECATED_MSG_ATTRIBUTE("Replaced by `GULOSLogInfo`."); | ||
| extern void GULLogDebug( | ||
| GULLoggerService service, BOOL force, NSString *messageCode, NSString *message, ...) | ||
| NS_FORMAT_FUNCTION(4, 5) DEPRECATED_MSG_ATTRIBUTE("Replaced by `GULOSLogDebug`."); |
There was a problem hiding this comment.
Just as a reminder, when you move these functions to a new file internally, these were the ones I forget to remove the DEPRECATED_MSG_ATTRIBUTE from.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.