Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove leftover #undef GUL_LOGGING_FUNCTION #205

Merged
merged 1 commit into from
Jul 25, 2024
Merged

Remove leftover #undef GUL_LOGGING_FUNCTION #205

merged 1 commit into from
Jul 25, 2024

Conversation

andrewheard
Copy link
Collaborator

Removed an extraneous #undef GUL_LOGGING_FUNCTION (leftover from the macro for the deprecated functions -- already deleted).

@andrewheard andrewheard requested a review from ncooke3 July 12, 2024 16:33
@google-oss-bot
Copy link

Coverage Report 1

Affected Products

No changes between base commit (3057f5d) and merge commit (935f513).

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/86cOfNPzDI.html

@ncooke3 ncooke3 requested a review from paulb777 July 25, 2024 16:14
@ncooke3
Copy link
Member

ncooke3 commented Jul 25, 2024 •
edited
Loading

@paulb777, does this look good to merge to you? Is there a reason to undef GUL_LOGGING_FUNCTION before defining it? I agree with Andrew that it looks extraneous but want to check in case you see anything that could mean it's not.

paulb777
paulb777 approved these changes Jul 25, 2024
View reviewed changes
Copy link
Member

@paulb777 paulb777 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be fine. Although I'm not sure why this was here in the first place.

@ncooke3 ncooke3 merged commit 9b3e8d4 into main Jul 25, 2024
21 checks passed
@ncooke3 ncooke3 deleted the ah/leftover-undef branch July 25, 2024 19:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paulb777 paulb777 paulb777 approved these changes

@ncooke3 ncooke3 ncooke3 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@andrewheard @google-oss-bot @ncooke3 @paulb777