Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GULMulticastUserNotificationCenterDelegate #71

Open
wants to merge 2 commits into
base: char-multicast-feature
Choose a base branch
from

Conversation

charlotteliang
Copy link
Contributor

@charlotteliang charlotteliang commented Feb 9, 2022

Add GULMulticastUserNotificationCenterDelegate to cast delegate methods from UNUserNotificationCenter used by Messaging to handle notification open and foreground tracking in Analytics.

@charlotteliang charlotteliang changed the base branch from main to char-multicast-feature February 9, 2022 20:32
@google-oss-bot
Copy link

google-oss-bot commented Feb 9, 2022

Copy link
Member

@paulb777 paulb777 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are unit tests needed?

Even if not, there should still be a pod lib lint build test added to CI

}

+ (id<GULMulticastNotificationProtocol>)multicastDelegate {
if (@available(iOS 10.0, *)) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not an API_AVAILABLE(ios(10.0) on the api instead?

@@ -12,7 +12,8 @@
// See the License for the specific language governing permissions and
// limitations under the License.

#import "GoogleUtilitiesMulticastAppDelegate/Sources/Public/GoogleUtilities/GULMulticastAppDelegate.h"
#import <GoogleUtilitiesMulticastAppDelegate/GULMulticastAppDelegate.h>
//#import <GoogleUtilities/GULAppDelegateSwizzler.h>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Delete

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants