-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add GULMulticastUserNotificationCenterDelegate #71
base: char-multicast-feature
Are you sure you want to change the base?
Conversation
Coverage Report 1Affected ProductsNo changes between base commit (8c4fcf6) and merge commit (68e2244).Test Logs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are unit tests needed?
Even if not, there should still be a pod lib lint
build test added to CI
} | ||
|
||
+ (id<GULMulticastNotificationProtocol>)multicastDelegate { | ||
if (@available(iOS 10.0, *)) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why not an API_AVAILABLE(ios(10.0)
on the api instead?
@@ -12,7 +12,8 @@ | |||
// See the License for the specific language governing permissions and | |||
// limitations under the License. | |||
|
|||
#import "GoogleUtilitiesMulticastAppDelegate/Sources/Public/GoogleUtilities/GULMulticastAppDelegate.h" | |||
#import <GoogleUtilitiesMulticastAppDelegate/GULMulticastAppDelegate.h> | |||
//#import <GoogleUtilities/GULAppDelegateSwizzler.h> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Delete
Add GULMulticastUserNotificationCenterDelegate to cast delegate methods from UNUserNotificationCenter used by Messaging to handle notification open and foreground tracking in Analytics.