Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update METADATA.pb #8332

Closed
wants to merge 1 commit into from
Closed

Update METADATA.pb #8332

wants to merge 1 commit into from

Conversation

chuckxiong0211
Copy link
Collaborator

Removing subsets: "latin" as Libre Barcode EAN13 Text is a barcode font that only supports numbers and some alphabets.

Using the pre-defined sample_text should be enough to showcase what this font is capable of doing.

Removing `subsets: "latin"` as `Libre Barcode EAN13 Text` is a barcode font that only supports numbers and some alphabets. 

Using the pre-defined `sample_text` should be enough to showcase what this font is capable of doing.
Copy link

FontBakery report

fontbakery version: 0.13.0a1

Check results

[29] LibreBarcodeEAN13Text-Regular.ttf
💥 ERROR Check if the vertical metrics of a CJK family are similar to the same family hosted on Google Fonts.
  • 💥 ERROR

    'Font' object is not subscriptable


    [code: error]
💥 ERROR Check if the vertical metrics of a family are similar to the same family hosted on Google Fonts.
  • 💥 ERROR

    'Font' object is not subscriptable


    [code: error]
💥 ERROR Check if the axes match between the font and the Google Fonts version.
  • 💥 ERROR

    'Font' object is not subscriptable


    [code: error]
🔥 FAIL Check METADATA.pb includes production subsets.
  • 🔥 FAIL

    The following subsets are missing [latin]


    [code: missing-subsets]
🔥 FAIL METADATA.pb should contain at least "menu" and "latin" subsets.
  • 🔥 FAIL

    Subsets "menu" and "latin" are mandatory, but METADATA.pb is missing "latin".


    [code: missing]
🔥 FAIL Shapes languages in all GF glyphsets.
  • 🔥 FAIL

    No GF glyphset was found to be supported >80%, so language shaping support couldn't get checked.


    [code: no-glyphset-supported]
🔥 FAIL Check Google Fonts glyph coverage.
  • 🔥 FAIL

    Missing required codepoints:

- 0x0021 (EXCLAMATION MARK)


- 0x0022 (QUOTATION MARK)


- 0x0023 (NUMBER SIGN)


- 0x0024 (DOLLAR SIGN)


- 0x0025 (PERCENT SIGN)


- 0x0026 (AMPERSAND)


- 0x0027 (APOSTROPHE)


- 0x002C (COMMA)


- 0x002E (FULL STOP)


- 0x002F (SOLIDUS)


- 159 more.

Use -F or --full-lists to disable shortening of long lists.

[code: missing-codepoints]
⚠️ WARN The font should not need a DSIG table anymore.
  • ⚠️ WARN

    This font has a digital signature (DSIG table) which is only required - even if only a placeholder - on old programs like MS Office 2013 in order to work properly.
    The current recommendation is to completely remove the DSIG table.


    [code: found-DSIG]
⚠️ WARN Check if each glyph has the recommended amount of contours.
  • ⚠️ WARN

    This check inspects the glyph outlines and detects the total number of contours in each of them. The expected values are infered from the typical ammounts of contours observed in a large collection of reference font families. The divergences listed below may simply indicate a significantly different design on some of your glyphs. On the other hand, some of these may flag actual bugs in the font such as glyphs mapped to an incorrect codepoint. Please consider reviewing the design and codepoint assignment of these to make sure they are correct.

The following glyphs do not have the recommended number of contours:

- Glyph name: addOn.guard.twoDigit	Contours detected: 2	Expected: 1
  • Glyph name: guard.centre Contours detected: 2 Expected: 1 or 4

  • Glyph name: guard.normal.triggerAddOn Contours detected: 2 Expected: 1

  • Glyph name: zero.compatibility Contours detected: 5 Expected: 2 or 3

  • Glyph name: one.compatibility Contours detected: 3 Expected: 1

  • Glyph name: two.compatibility Contours detected: 3 Expected: 1

  • Glyph name: three.compatibility Contours detected: 3 Expected: 1

  • Glyph name: four.compatibility Contours detected: 4 Expected: 1 or 2

  • Glyph name: five.compatibility Contours detected: 3 Expected: 1

  • Glyph name: six.compatibility Contours detected: 4 Expected: 1 or 2

  • 92 more.

Use -F or --full-lists to disable shortening of long lists.

[code: contour-count]
⚠️ WARN Check math signs have the same width.
  • ⚠️ WARN

    The most common width is 84 among a set of 4 math glyphs.
    The following math glyphs have a different width, though:

Width = 36: guard.normal.triggerAddOn

[code: width-outliers]
⚠️ WARN Combined length of family and style must not exceed 32 characters.
  • ⚠️ WARN

    Name ID 6 'LibreBarcodeEAN13Text-Regular' exceeds 27 characters. This has been found to cause problems with PostScript printers, especially on Mac platforms.


    [code: nameid6-too-long]
⚠️ WARN Validate size, and resolution of article images, and ensure article page has minimum length and includes visual assets.
  • ⚠️ WARN

    Family metadata at ofl/librebarcodeean13text does not have an article.


    [code: lacks-article]
⚠️ WARN METADATA.pb: Designers are listed correctly on the Google Fonts catalog?
  • ⚠️ WARN

    It seems that Lasse Fister is still not listed on the designers catalog. Please submit a photo and a link to a webpage where people can learn more about the work of this designer/typefoundry.


    [code: profile-not-found]
⚠️ WARN Check for codepoints not covered by METADATA subsets.
  • ⚠️ WARN

    The following codepoints supported by the font are not covered by
    any subsets defined in the font's metadata file, and will never
    be served. You can solve this by either manually adding additional
    subset declarations to METADATA.pb, or by editing the glyphset
    definitions.

  • U+200C ZERO WIDTH NON-JOINER: try adding one of: tai-le, hebrew, sogdian, tibetan, khojki, takri, tirhuta, buhid, psalter-pahlavi, sundanese, brahmi, oriya, cham, telugu, dogra, malayalam, siddham, chakma, bengali, arabic, devanagari, khudawadi, gunjala-gondi, hanunoo, lepcha, lao, thaana, kayah-li, newa, grantha, masaram-gondi, tamil, new-tai-lue, tai-tham, tifinagh, zanabazar-square, kannada, hatran, avestan, tai-viet, gurmukhi, gujarati, kharoshthi, warang-citi, duployan, meetei-mayek, manichaean, sharada, javanese, thai, batak, rejang, mandaic, sinhala, tagalog, balinese, limbu, myanmar, mahajani, nko, saurashtra, bhaiksuki, kaithi, khmer, phags-pa, buginese, yi, tagbanwa, modi, mongolian, pahawh-hmong, syloti-nagri, syriac, hanifi-rohingya

Or you can add the above codepoints to one of the subsets supported by the font: menu

[code: unreachable-subsetting]
⚠️ WARN On a family update, the DESCRIPTION.en_us.html file should ideally also be updated.
  • ⚠️ WARN

    The DESCRIPTION.en_us.html file in this family has not changed in comparison to the latest font release on the google/fonts github repo.
    Please consider mentioning note-worthy improvements made to the family recently.


    [code: description-not-updated]
⚠️ WARN Check copyright namerecords match license file.
⚠️ WARN Are there any misaligned on-curve points?
  • ⚠️ WARN

    The following glyphs have on-curve points which have potentially incorrect y coordinates:

* eight.below (U+0073): X=42.0,Y=-118.0 (should be at descender -120?)

* eight.below (U+0073): X=42.0,Y=-118.0 (should be at descender -120?)

* eight.below.upcquietzone (U+02DA): X=24.0,Y=-118.0 (should be at descender -120?)

* eight.below.upcquietzone (U+02DA): X=24.0,Y=-118.0 (should be at descender -120?)

* eight.compatibility (U+0038): X=42.0,Y=-118.0 (should be at descender -120?)

* eight.compatibility (U+0038): X=42.0,Y=-118.0 (should be at descender -120?)

* eight.ean8.setA (U+00C8): X=42.0,Y=-118.0 (should be at descender -120?)

* eight.ean8.setA (U+00C8): X=42.0,Y=-118.0 (should be at descender -120?)

* eight.ean8.setC (U+00D2): X=42.0,Y=-118.0 (should be at descender -120?)

* eight.ean8.setC (U+00D2): X=42.0,Y=-118.0 (should be at descender -120?)

* 70 more.

Use -F or --full-lists to disable shortening of long lists.

[code: found-misalignments]
⚠️ WARN Do any segments have colinear vectors?
  • ⚠️ WARN

    The following glyphs have colinear vectors:

* checkdigit.marker (U+003F): L<<118.0,517.0>--<110.0,523.0>> -> L<<110.0,523.0>--<64.0,561.0>>

* three (U+2019): L<<69.0,60.0>--<115.0,115.0>> -> L<<115.0,115.0>--<122.0,123.0>>

* three.below.upcquietzone (U+00FF): L<<2.0,-109.0>--<8.0,-103.0>> -> L<<8.0,-103.0>--<9.0,-102.0>>

* two.below.upcquietzone (U+00FE): L<<9.0,-61.0>--<8.0,-61.0>> -> L<<8.0,-61.0>--<7.0,-61.0>>

[code: found-colinear-vectors]

⚠️ WARN Are any segments inordinately short?
  • ⚠️ WARN

    The following glyphs have segments which seem very short:

* checkdigit.marker (U+003F) contains a short segment L<<118.0,517.0>--<110.0,523.0>>

* five (U+201C) contains a short segment L<<128.0,133.0>--<132.0,128.0>>

* five (U+201C) contains a short segment B<<132.0,128.0>-<131.0,119.0>-<134.0,112.0>>

* five.addOn.setA (U+00ED) contains a short segment L<<22.0,749.0>--<22.0,748.0>>

* five.addOn.setB (U+00F7) contains a short segment L<<22.0,749.0>--<22.0,748.0>>

* five.below (U+0070) contains a short segment L<<22.0,-94.0>--<22.0,-95.0>>

* five.below.upcquietzone (U+0152) contains a short segment L<<9.0,-101.0>--<10.0,-101.0>>

* five.below.upcquietzone (U+0152) contains a short segment B<<10.0,-101.0>-<10.0,-102.0>-<10.0,-103.0>>

* five.compatibility (U+0035) contains a short segment L<<22.0,-94.0>--<22.0,-95.0>>

* five.ean8.setA (U+00C5) contains a short segment L<<22.0,-94.0>--<22.0,-95.0>>

* 80 more.

Use -F or --full-lists to disable shortening of long lists.

[code: found-short-segments]
⚠️ WARN Ensure fonts have ScriptLangTags declared on the 'meta' table.
  • ⚠️ WARN

    This font file does not have a 'meta' table.


    [code: lacks-meta-table]
⚠️ WARN Font has old ttfautohint applied?
  • ⚠️ WARN

    ttfautohint used in font = 1.8.3; latest = 1.8.4; Need to re-run with the newer version!


    [code: old-ttfa]
ℹ️ INFO List all superfamily filepaths
  • ℹ️ INFO

    ofl/librebarcodeean13text


    [code: family-path]
ℹ️ INFO Show hinting filesize impact.
  • ℹ️ INFO

    Hinting filesize impact:

ofl/librebarcodeean13text/LibreBarcodeEAN13Text-Regular.ttf
Dehinted Size 54.1kb
Hinted Size 71.0kb
Increase 16.8kb
Change 31.1 %
[code: size-impact]
ℹ️ INFO Font contains all required tables?
  • ℹ️ INFO

    This font contains the following optional tables:

- cvt 

- fpgm

- loca

- prep

- GPOS

- GSUB

- gasp

[code: optional-tables]

ℹ️ INFO METADATA.pb: Validate family.minisite_url field.
  • ℹ️ INFO

    Please consider adding a family.minisite_url entry.


    [code: lacks-minisite-url]
ℹ️ INFO Does DESCRIPTION file contain a upstream Git repo URL?
ℹ️ INFO Check for presence of an ARTICLE.en_us.html file
  • ℹ️ INFO

    This font doesn't have an ARTICLE.en_us.html file.


    [code: missing-article]
ℹ️ INFO EPAR table present in font?
ℹ️ INFO Is the Grid-fitting and Scan-conversion Procedure ('gasp') table set to optimize rendering?
  • ℹ️ INFO

    These are the ppm ranges declared on the gasp table:

PPM <= 65535: flag = 0x0F - Use grid-fitting - Use grayscale rendering - Use gridfitting with ClearType symmetric smoothing - Use smoothing along multiple axes with ClearType®

[code: ranges]
[2] Family checks
🔥 FAIL OS/2.fsSelection bit 7 (USE_TYPO_METRICS) is set in all fonts.
  • 🔥 FAIL

    OS/2.fsSelection bit 7 (USE_TYPO_METRICS) wasNOT set in the following fonts: ['ofl/librebarcodeean13text/LibreBarcodeEAN13Text-Regular.ttf'].


    [code: missing-os2-fsselection-bit7]
ℹ️ INFO Check axis ordering on the STAT table.
  • ℹ️ INFO

    All of the fonts lack a STAT table.


    [code: summary]

Summary

💥 ERROR ☠ FATAL 🔥 FAIL ⚠️ WARN ⏩ SKIP ℹ️ INFO ✅ PASS 🔎 DEBUG
3 0 5 14 71 9 151 0
1% 0% 2% 6% 28% 4% 60% 0%

Note: The following loglevels were omitted in this report:

  • SKIP
  • PASS
  • DEBUG

@chuckxiong0211 chuckxiong0211 marked this pull request as draft October 15, 2024 18:28
@chuckxiong0211 chuckxiong0211 deleted the chuckxiong0211-barcode branch October 15, 2024 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant