Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Remove redundant local vars in examples #3303

Merged
merged 1 commit into from
Oct 3, 2024

Conversation

alexandear
Copy link
Contributor

@alexandear alexandear commented Oct 3, 2024

The PR proposes removing local variables such as bytePassword and secretBytes because they do not significantly enhance readability.

Copy link

codecov bot commented Oct 3, 2024

Codecov Report

Attention: Patch coverage is 0% with 9 lines in your changes missing coverage. Please review.

Project coverage is 93.05%. Comparing base (2b8c7fa) to head (cbdcbef).
Report is 131 commits behind head on master.

Files with missing lines Patch % Lines
example/basicauth/main.go 0.00% 2 Missing ⚠️
example/tagprotection/main.go 0.00% 2 Missing ⚠️
example/tokenauth/main.go 0.00% 2 Missing ⚠️
...xample/codespaces/newreposecretwithxcrypto/main.go 0.00% 1 Missing ⚠️
...xample/codespaces/newusersecretwithxcrypto/main.go 0.00% 1 Missing ⚠️
example/newreposecretwithxcrypto/main.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3303      +/-   ##
==========================================
- Coverage   97.72%   93.05%   -4.67%     
==========================================
  Files         153      172      +19     
  Lines       13390    11771    -1619     
==========================================
- Hits        13085    10954    -2131     
- Misses        215      723     +508     
- Partials       90       94       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@gmlewis gmlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @alexandear !
LGTM.
Merging.

@gmlewis gmlewis merged commit c0f593d into google:master Oct 3, 2024
5 of 7 checks passed
@alexandear alexandear deleted the refactor/example-redundant-vars branch October 4, 2024 07:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants