Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include j2objc-annotations in the Gradle runtime classpath. #7400

Merged
merged 1 commit into from
Sep 23, 2024

Conversation

copybara-service[bot]
Copy link
Contributor

@copybara-service copybara-service bot commented Sep 23, 2024

Include j2objc-annotations in the Gradle runtime classpath.

While that artifact contains no runtime-retention annotations, it does contain class-retention annotations (which could drive a runtime bytecode-rewriting agent). And, more practically, the Android Gradle Plugin has started reporting errors for compileOnly dependencies.

Fixes #7397

Relevant to firebase/firebase-android-sdk#6232 and androidx/media#1700

RELNOTES=Added j2objc-annotations to the Gradle runtime classpath to avoid an Android Gradle Plugin error.

While that artifact contains no runtime-retention annotations, it does contain class-retention annotations (which could drive a runtime bytecode-rewriting agent). And, more practically, the Android Gradle Plugin has started reporting errors for `compileOnly` dependencies.

Fixes #7397

Relevant to firebase/firebase-android-sdk#6232 and androidx/media#1700

RELNOTES=Added `j2objc-annotations` to the Gradle runtime classpath to avoid [an Android Gradle Plugin error](#7397).
PiperOrigin-RevId: 677842769
@copybara-service copybara-service bot merged commit a3b5188 into master Sep 23, 2024
2 checks passed
@copybara-service copybara-service bot deleted the test_677781422 branch September 23, 2024 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

com.google.j2objc:j2objc-annotations compileOnly dependency not supported on Android
1 participant