Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Void parameter sets should not require declaration #2

Open
jwhpryor opened this issue May 24, 2022 · 5 comments
Open

Void parameter sets should not require declaration #2

jwhpryor opened this issue May 24, 2022 · 5 comments
Labels
enhancement New feature or request good first issue Good for newcomers
Milestone

Comments

@jwhpryor
Copy link
Collaborator

Empty returns, constructors, and methods should not require specification.

@jwhpryor jwhpryor added the enhancement New feature or request label May 24, 2022
@jwhpryor jwhpryor added the good first issue Good for newcomers label Dec 21, 2022
@Harshitjoshi133
Copy link

Can I work on it

@jwhpryor
Copy link
Collaborator Author

jwhpryor commented Mar 7, 2023

Sure! I would start by looking at class.h and method.h. Also, I don't know what your setup is like, and I wouldn't be surprised if you need to resolve some blockages (i.e. #42).

This is obviously gating for 1.0 release, but I may not be able to do much in the immediate term. If you can unblock that, it would be a help.

@Harshitjoshi133
Copy link

Harshitjoshi133 commented Mar 7, 2023

I thought it would be easy but now I am not getting what to do

@jwhpryor
Copy link
Collaborator Author

jwhpryor commented Mar 8, 2023

Basically, ::jni::Method take ::jni::Params which is tedious if there are no params.

i.e. I must write this:

Method {"Foo", Return{}, Params{}}

when I want to write this:

Method {"Foo", Return{}}

The task is to write a constructor for Method (and probably a CTAD guide) so this is possible.

@jwhpryor jwhpryor added this to the Release 1.1 milestone Mar 18, 2024
copybara-service bot pushed a commit that referenced this issue Mar 23, 2024
copybara-service bot pushed a commit that referenced this issue Mar 23, 2024
copybara-service bot pushed a commit that referenced this issue Mar 23, 2024
copybara-service bot pushed a commit that referenced this issue Mar 25, 2024
copybara-service bot pushed a commit that referenced this issue Mar 25, 2024
@jwhpryor
Copy link
Collaborator Author

jwhpryor commented Jul 3, 2024

I seem to be seeing issues when these classes are being used as return values in chained calls. I'm going to investigate.

@jwhpryor jwhpryor reopened this Jul 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants