Support new Android Studio and Gradle versions #122
Conversation
Compiling this library was very tough due to gradle version related issues. The gradle versions have now been updated to latest.
|
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed, please reply here (e.g.
|
|
I signed it! |
|
CLAs look good, thanks! |
| @@ -54,7 +54,7 @@ android { | |||
| * The obvious way to fix this would be allow wildcards (ie, "22.+") but | |||
| * Android have explicitly said that they won't do this. | |||
| */ | |||
| compileSdkVersion 22 | |||
| buildToolsVersion '21.1.2' | |||
| compileSdkVersion 25 | |||
There was a problem hiding this comment.
The commit message does not mention anything about changing the SDK version. Is this change intentional? If it is, it should be explained the the commit message why it's being done.
| <instrumentation | ||
| android:name="android.test.InstrumentationTestRunner" | ||
| android:targetPackage="com.android.i18n.addressinput.test" /> | ||
| <!--<instrumentation--> |
There was a problem hiding this comment.
This does not look good. Either this block is no longer necessary, in which case it should be deleted together with the comment explaining its purpose and the commit message updated to explain why it's no longer necessary, or else it should not be commented out.
| @@ -23,3 +23,4 @@ allprojects { | |||
| mavenLocal() | |||
| } | |||
| } | |||
|
|
|||
There was a problem hiding this comment.
This looks like a mistake. (Or is there really a reason for why it's an improvement to add a blank line here?)
Change Gradle version to 3.3 and add gradle wrapper.