Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[libaddressinput] add missing dependencies to gradle build files and update to Gradle 8.2.2 #240

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

[libaddressinput] add missing dependencies to gradle build files and update to Gradle 8.2.2 #240

wants to merge 2 commits into from

Conversation

andrew12678
Copy link

@andrew12678 andrew12678 commented May 3, 2024 •
edited
Loading

  • An internal google update added dependencies only to internal google BUILD files and not the gradle.build file which breaks open source users of this codebasee
  • Also upgrade the gradle version so modern Android studio users can actually build this
  • I've verified that the tests work screenshot

@andrew12678
[libaddressinput] add missing dependencies to gradle build files and …
70d480e 
…update to Gradle 8.2.2

- An internal google update added dependencies only to internal google BUILD files and not the gradle.build file which breaks open source users of this codebase
- Also upgrade the gradle version so modern Android studio users can actually build this
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@battre battre battre approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@andrew12678 @battre