Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Various Windows fixes #37

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Conversation

SneezingCactus
Copy link

Various fixes that make santa-tracker-web usable on Windows. It mostly fixes path issues.

Various fixes that make santa-tracker-web usable on Windows.
@google-cla
Copy link

google-cla bot commented Dec 2, 2020

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@SneezingCactus
Copy link
Author

@googlebot I signed it!

@samthor
Copy link
Contributor

samthor commented Dec 26, 2020

@SneezingCactus thank you again for this fix. Some feedback:

  • can we keep using yargs.prefix but change its default value to be a path that makes sense on Windows?
  • similar for Closure, I wonder if we can keep the regex but normalize the input path to match it

I definitely want to get it in, I'm just concerned this breaks my dev flow a bit.

@SneezingCactus
Copy link
Author

I'll see what I can do to fix it

@SneezingCactus
Copy link
Author

The problem with yargs.prefix is that js files try to get files from static but repeats "../" way too much and it goes outside /st/ or whatever the prefix is. I can't fix those js files because they're compiled by google closure which changes the require paths.

One possible fix without removing yargs.prefix would be making static be accessible even without the prefix on, so for example, static could be accessed on both "localhost:8080/" and "localhost:8080/st/". It's quite hacky though.

Another possible fix would be changing google closure itself.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants