-
Notifications
You must be signed in to change notification settings - Fork 155
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Various Windows fixes #37
base: main
Are you sure you want to change the base?
Conversation
Various fixes that make santa-tracker-web usable on Windows.
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
@googlebot I signed it! |
@SneezingCactus thank you again for this fix. Some feedback:
I definitely want to get it in, I'm just concerned this breaks my dev flow a bit. |
I'll see what I can do to fix it |
The problem with yargs.prefix is that js files try to get files from static but repeats "../" way too much and it goes outside /st/ or whatever the prefix is. I can't fix those js files because they're compiled by google closure which changes the require paths. One possible fix without removing yargs.prefix would be making static be accessible even without the prefix on, so for example, static could be accessed on both "localhost:8080/" and "localhost:8080/st/". It's quite hacky though. Another possible fix would be changing google closure itself. |
Various fixes that make santa-tracker-web usable on Windows. It mostly fixes path issues.