Skip to content

Mark TCMALLOC_PER_CPU_CACHE_SIZE_1MB as inactive. #616

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
copybara-service wants to merge 1 commit into
base: master
Choose a base branch
from
+0 −5
Draft

Mark TCMALLOC_PER_CPU_CACHE_SIZE_1MB as inactive. #616

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions tcmalloc/experiment_config.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,6 @@ enum class Experiment : int {
// go/keep-sorted start
TCMALLOC_DEMAND_CYCLE_120S, // TODO: b/540987155 - Complete experiment.
TCMALLOC_HUGE_REGION_ADAPTIVE_RELEASE, // TODO: b/535197873 - Complete experiment.
TCMALLOC_PER_CPU_CACHE_SIZE_1MB, // TODO: b/514747820 - Complete experiment.
TCMALLOC_PGHO_EXPERIMENT, // TODO: b/460486507 - Complete experiment.
TCMALLOC_REUSE_SIZE_CLASSES_ABLATION, // TODO: b/524296402 - Complete experiment.
TCMALLOC_SONIC_MADVISE_SAMPLED_ALLOCATIONS_HOLDBACK, // TODO: b/540945006 - Complete experiment.
Expand Down Expand Up @@ -56,7 +55,6 @@ inline constexpr ExperimentConfig experiments[] = {
// go/keep-sorted start
{Experiment::TCMALLOC_DEMAND_CYCLE_120S, "TCMALLOC_DEMAND_CYCLE_120S"},
{Experiment::TCMALLOC_HUGE_REGION_ADAPTIVE_RELEASE, "TCMALLOC_HUGE_REGION_ADAPTIVE_RELEASE"},
{Experiment::TCMALLOC_PER_CPU_CACHE_SIZE_1MB, "TCMALLOC_PER_CPU_CACHE_SIZE_1MB"},
{Experiment::TCMALLOC_PGHO_EXPERIMENT, "TCMALLOC_PGHO_EXPERIMENT"},
{Experiment::TCMALLOC_REUSE_SIZE_CLASSES_ABLATION, "TCMALLOC_REUSE_SIZE_CLASSES_ABLATION"},
{Experiment::TCMALLOC_SONIC_MADVISE_SAMPLED_ALLOCATIONS_HOLDBACK, "TCMALLOC_SONIC_MADVISE_SAMPLED_ALLOCATIONS_HOLDBACK", /*brittle=*/false, /*force_disable=*/false, /*rollout_lower_bound=*/0, /*rollout_upper_bound=*/0.5},
Expand Down
3 changes: 0 additions & 3 deletions tcmalloc/static_vars.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -210,9 +210,6 @@ ABSL_ATTRIBUTE_COLD ABSL_ATTRIBUTE_NOINLINE void Static::SlowInitIfNecessary() {
}
(void)subtle::percpu::IsFast();
PerCpuState::state().Init();
if (IsExperimentActive(Experiment::TCMALLOC_PER_CPU_CACHE_SIZE_1MB)) {
cpu_cache_.SetCacheLimit(/*v=*/1024 * 1024);
}
numa_topology_.Init();
CacheTopology::Instance().Init();

Expand Down
Loading