Test that force_disable overrides hostname-hash experiment rollout. - #638
Draft
copybara-service[bot] wants to merge 1 commit into
Draft
Test that force_disable overrides hostname-hash experiment rollout.#638copybara-service[bot] wants to merge 1 commit into
copybara-service[bot] wants to merge 1 commit into
Conversation
SelectExperiments applies force_disable after rollout enablement, so a force_disabled experiment stays disabled even when the host falls within its rollout bucket. No production experiment is simultaneously force_disabled and in rollout, so this ordering was previously untested. Add a `configs` parameter to SelectExperiments so a test can inject a synthetic experiment that is both force_disabled and at 100% rollout and assert it remains disabled. A positive control confirms rollout still enables the same experiment once force_disable is cleared. PiperOrigin-RevId: 974520832
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Test that force_disable overrides hostname-hash experiment rollout.
SelectExperiments applies force_disable after rollout enablement, so a
force_disabled experiment stays disabled even when the host falls within its
rollout bucket. No production experiment is simultaneously force_disabled and
in rollout, so this ordering was previously untested. Add a
configsparameter to SelectExperiments
so a test can inject a synthetic experiment that is both force_disabled and at
100% rollout and assert it remains disabled. A positive control confirms
rollout still enables the same experiment once force_disable is cleared.