Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Revision history] Move Schedule Revision history out of the spec amendment process and add the realtime revision history to this repo #467

Merged
merged 2 commits into from
Jun 3, 2024

Conversation

isabelle-dr
Copy link
Collaborator

Problems with the revision history

  1. the GTFS Realtime revision history is not part of this repo, although was part of the initial gtfs.org repo to appear on gtfs.org. Additionally, it's out of date.
  2. the GTFS Schedule revision history appears after the spec amendment process.
    We're reorganizing content on gtfs.org to enhance the user experience. The revision history will be placed in a new Technical Documentation section, and the Spec Amendment Process will be moved to a Community section, which will include information on how to participate. To achieve this, we need these to be two separate documents. Also, the revision history is actively maintained, while the Spec Amendment Process rarely changes, so having them in separate documents will make things clearer.

Solution included in this PR

  • Moved the GTFS Schedule revision history out of the spec amendment process in its own document
  • Added the GTFS Realtime revision history to this repo
  • Updated the GTFS Realtime revision history

This doesn't change the spec or its amendment process, so I believe a vote is not needed.

@niels-penneman
Copy link

This looks like a proper solution to the issue I logged earlier this month on gtfs.org (MobilityData/gtfs.org#445).

@eliasmbd eliasmbd added GTFS Schedule Issues and Pull Requests that focus on GTFS Schedule GTFS Realtime Issues and Pull Requests that focus on GTFS Realtime Status: Discussion Issues and Pull Requests that are currently being discussed and reviewed by the community. Change: Editorial Inconsequential changes to the specification such as link updates, grammatical errors, formatting. labels May 28, 2024
Copy link
Collaborator

@Sergiodero Sergiodero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this @isabelle-dr, Changes look good to me!

@isabelle-dr
Copy link
Collaborator Author

@niels-penneman indeed :)

@isabelle-dr
Copy link
Collaborator Author

Thanks for the review @Sergiodero!
After a few days and a review, I am merging this PR, considering it a repo maintenance item that doesn't need a vote.
This does not change the spec or the amendment process in any way.

@isabelle-dr isabelle-dr merged commit ea80ebb into google:master Jun 3, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Change: Editorial Inconsequential changes to the specification such as link updates, grammatical errors, formatting. GTFS Realtime Issues and Pull Requests that focus on GTFS Realtime GTFS Schedule Issues and Pull Requests that focus on GTFS Schedule Status: Discussion Issues and Pull Requests that are currently being discussed and reviewed by the community.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants