WIP Add ctap hid api #539
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||||
|---|---|---|---|---|---|---|---|---|
| @@ -0,0 +1,79 @@ | ||||||||
| // Copyright 2024 Google LLC | ||||||||
| // | ||||||||
| // Licensed under the Apache License, Version 2.0 (the "License"); | ||||||||
| // you may not use this file except in compliance with the License. | ||||||||
| // You may obtain a copy of the License at | ||||||||
| // | ||||||||
| // http://www.apache.org/licenses/LICENSE-2.0 | ||||||||
| // | ||||||||
| // Unless required by applicable law or agreed to in writing, software | ||||||||
| // distributed under the License is distributed on an "AS IS" BASIS, | ||||||||
| // WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||||||||
| // See the License for the specific language governing permissions and | ||||||||
| // limitations under the License. | ||||||||
|
|
||||||||
| use crate::*; | ||||||||
|
|
||||||||
| pub(crate) fn new() -> Item { | ||||||||
| let docs = docs!(); | ||||||||
| let name = "ctap".into(); | ||||||||
| let items = vec![ | ||||||||
| item! { | ||||||||
| /// Reads from USB serial into a buffer. | ||||||||
| /// | ||||||||
| /// Returns the number of bytes read. This function does not block and may return zero. | ||||||||
| fn read "usr" { | ||||||||
|
There was a problem hiding this comment. You'll need to allocate new unique identifiers, e.g. changing the |
||||||||
| /// Address of the buffer. | ||||||||
|
There was a problem hiding this comment.
Suggested change
|
||||||||
| ptr: *mut u8, | ||||||||
|
|
||||||||
| /// Length of the buffer in bytes. | ||||||||
| len: usize, | ||||||||
|
Comment on lines
+29
to
+30
There was a problem hiding this comment. we don't need this now that we fix the packet size |
||||||||
| } -> usize | ||||||||
| }, | ||||||||
| item! { | ||||||||
| /// Writes to USB serial from a buffer. | ||||||||
|
|
||||||||
| /// | ||||||||
| /// Returns the number of bytes written. This function does not block and may return | ||||||||
| /// zero. | ||||||||
| fn write "usw" { | ||||||||
| /// Address of the buffer. | ||||||||
| ptr: *const u8, | ||||||||
|
|
||||||||
| /// Length of the buffer in bytes. | ||||||||
| len: usize, | ||||||||
| } -> usize | ||||||||
| }, | ||||||||
| item! { | ||||||||
| /// USB serial events. | ||||||||
|
There was a problem hiding this comment.
Suggested change
|
||||||||
| enum Event { | ||||||||
| /// Ready for read. | ||||||||
| Read = 0, | ||||||||
| /// Ready for write. | ||||||||
| Write = 1, | ||||||||
| } | ||||||||
| }, | ||||||||
| item! { | ||||||||
| /// Registers a callback when USB serial is ready. | ||||||||
|
There was a problem hiding this comment.
Suggested change
|
||||||||
| /// | ||||||||
| /// It is possible that the callback is spuriously called. The callback is only | ||||||||
| /// guaranteed to be called after the associated operation processed less bytes than the | ||||||||
| /// buffer size. | ||||||||
|
Comment on lines
+59
to
+60
There was a problem hiding this comment.
Suggested change
|
||||||||
| fn register "use" { | ||||||||
| event: usize, | ||||||||
| handler_func: fn { data: *const void }, | ||||||||
| handler_data: *const void, | ||||||||
| } -> () | ||||||||
| }, | ||||||||
| item! { | ||||||||
| /// Unregisters a callback. | ||||||||
| fn unregister "usd" { | ||||||||
| event: usize, | ||||||||
| } -> () | ||||||||
| }, | ||||||||
| item! { | ||||||||
| /// Flushs the USB serial. | ||||||||
| fn flush "usf" {} -> () | ||||||||
| }, | ||||||||
|
Comment on lines
+73
to
+76
There was a problem hiding this comment. I don't think this function is needed. Let's remove it. |
||||||||
| ]; | ||||||||
| Item::Mod(Mod { docs, name, items }) | ||||||||
| } | ||||||||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.