feat(storage/dataflux): run worksteal listing parallel to sequential listing #10966
+553
−89
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-auto-label
bot
added
the
api: storage
BrennaEpp
reviewed
Oct 18, 2024
BrennaEpp
reviewed
Oct 25, 2024
storage/dataflux/fast_list.go
Outdated
| g.Go(func() error { | ||
| objects, err := c.workstealListing(childCtx) | ||
| if err != nil { | ||
| countError++ |
There was a problem hiding this comment.
Won't this be a race condition when c.method is open and both sequential and worksteal are running at the same time? Can we hit this case in a emulator test?
There was a problem hiding this comment.
Added unit test to catch this in the race conditions.
BrennaEpp
reviewed
Oct 25, 2024
… all workers as it can nott be reached
BrennaEpp
reviewed
Oct 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat: run worksteal listing parallel to sequential listing
Dataflux fast-listing leverages worksteal algorithm to quickly list objects in a bucket by running several parallel processes. Worksteal algorithm splits a given namespace into multiple ranges for multiple workers(goroutines) to list objects in gcs bucket in parallel.
Adding logic to list next page in worksteal listing and basic unit tests that uses storage/emulator.
Fixes #10731