Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(storage): adding request-id in the stall-retry log #11074

Merged
merged 3 commits into from
Nov 4, 2024
Merged

chore(storage): adding request-id in the stall-retry log #11074

merged 3 commits into from
Nov 4, 2024

Conversation

raj-prince
Copy link
Contributor

@raj-prince raj-prince commented Nov 1, 2024 •
edited
Loading

  1. Fixing the stall-timeout value in the log.
  2. Adding request-id in the log - this will be helpful for debugging.

Sample log:

2024/11/01 11:56:35 stalled read-req (0xc000232640) cancelled after 0.500000s
2024/11/01 11:56:37 stalled read-req (0xc000232640) cancelled after 0.523647s
2024/11/01 11:56:40 stalled read-req (0xc000232640) cancelled after 0.548412s

@product-auto-label product-auto-label bot added the api: storage Issues related to the Cloud Storage API. label Nov 1, 2024
@raj-prince raj-prince marked this pull request as ready for review November 1, 2024 14:20
@raj-prince raj-prince requested review from a team as code owners November 1, 2024 14:20
@raj-prince raj-prince changed the title chore(storage): adding request-id in the stalled log chore(storage): adding request-id in the stall-retry log Nov 1, 2024
@tritone tritone added the automerge Merge the pull request once unit tests and other checks pass. label Nov 4, 2024
@gcf-merge-on-green gcf-merge-on-green bot merged commit 5ff0fdc into googleapis:main Nov 4, 2024
8 checks passed
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Nov 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tritone tritone tritone approved these changes

Assignees
No one assigned
Labels
api: storage Issues related to the Cloud Storage API.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@raj-prince @tritone