feat(compute/metadata): add debug logging #11078
Conversation
codyoss
added
the
do not merge
product-auto-label
bot
added
the
api: compute
|
Requires googleapis/gax-go#380 |
| "net" | ||
| "net/http" | ||
| "net/url" | ||
| "os" | ||
| "strings" | ||
| "sync" | ||
| "time" | ||
|
|
||
| "github.com/googleapis/gax-go/v2/internallog" |
There was a problem hiding this comment.
is there any way to avoid this? compute/metadata is impossible to avoid as a dependency (google.golang.org/grpc pulls it in, etc)
we really should not be forcing transitive deps on cloud modules like this
There was a problem hiding this comment.
At this layer specifically we cloud likely just take slog as a dep and pass in a logger. But this means the default case can never work with the semantics we are adding here.
There was a problem hiding this comment.
compute/metadata specifically is required by almost everything in the go ecosystem, keeping its dependency graph small and avoiding transitive deps to other cloud libraries is much more important for this module than anything else in this repo.
using stdlib slog or a locally-defined interface and pushing callers to wire any specific cloud instrumentation they want is much more in line with what I would expect here.
I'd also like to see a presubmit that will catch / guard against unconsidered introduction of new dependencies to this module in particular
No description provided.