Update IsGoogleCloudServerless function to check for Cloud Run Worker Pools - #9226
Open
kcolton-jpg wants to merge 2 commits into
Open
Update IsGoogleCloudServerless function to check for Cloud Run Worker Pools#9226kcolton-jpg wants to merge 2 commits into
kcolton-jpg wants to merge 2 commits into
Conversation
…rmining if the environment is GCP Serverless Update the function for determining whether a environment is GCP Serverless to include K_CLOUD_RUN_WORKER_POOLS.
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the isGoogleCloudServerless detection logic to include the CLOUD_RUN_WORKER_POOL environment variable, along with its corresponding JSDoc documentation. The review feedback correctly identifies an invalid internal URL in the newly added documentation and suggests replacing it with the correct public Google Cloud documentation link.
| * | ||
| * `CLOUD_RUN_WORKER_POOL` is used in Cloud Run and newer Cloud Functions environments: | ||
| * - See {@link https://cloud.google.com/run/docs/container-contract#env-vars Cloud Run environment variables}. | ||
| * - See {@link http://cloud/run/docs/deploy-worker-pools Deploy Worker Pools to Cloud Run}. |
Contributor
There was a problem hiding this comment.
The URL http://cloud/run/docs/deploy-worker-pools is invalid and appears to be a typo or an internal link. It should be updated to the public documentation URL: https://cloud.google.com/run/docs/deploy-worker-pools.
Suggested change
| * - See {@link http://cloud/run/docs/deploy-worker-pools Deploy Worker Pools to Cloud Run}. | |
| * - See {@link https://cloud.google.com/run/docs/deploy-worker-pools Deploy Worker Pools to Cloud Run}. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes ##9225 🦕