ci: automate discovery types #1366
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-auto-label
bot
added
size: s
product-auto-label
bot
added
size: m
leahecole
reviewed
Jun 4, 2024
| on: | ||
| schedule: | ||
| - cron: '0 12 * * TUE' | ||
| pull_request: # REMOVE BEFORE MERGING |
There was a problem hiding this comment.
Suggested change
| pull_request: # REMOVE BEFORE MERGING | |
| pull_request: # REMOVE BEFORE MERGING |
Does this need to be removed now?
Comment on lines
+11
to
+12
| - uses: actions/checkout@a5ac7e51b41094c92402da3b24376905380afc29 # v4.1.6 | ||
| - uses: actions/setup-node@60edb5dd545a775178f52524783378180af0d1f8 # v4.0.2 |
There was a problem hiding this comment.
Do these get updated by dependabot or renovate bot? Wanting to make sure we're not adding a manual maintenance step of updating
| - uses: actions/checkout@a5ac7e51b41094c92402da3b24376905380afc29 # v4.1.6 | ||
| - uses: actions/setup-node@60edb5dd545a775178f52524783378180af0d1f8 # v4.0.2 | ||
| with: | ||
| node-version: 16 |
There was a problem hiding this comment.
same for this version about maintenance
Comment on lines
+59
to
+61
| "execa": "^5.0.0", | ||
| "extend": "^3.0.2", | ||
| "gaxios": "^6.0.3", |
There was a problem hiding this comment.
should these be dev dependencies instead of dependencies we're having the user add?
| 'Automated pull-request to keep BigQuery Discovery types up-to-date.'; | ||
|
|
||
| async function submitDiscoveryPR() { | ||
| const statusResult = await execa('git', ['status', '--porcelain']); |
There was a problem hiding this comment.
TIL git status porcelain! 😁
Comment on lines
+42
to
+43
| await execa('git', ['config', 'user.email', 'yoshi-automation@google.com']); | ||
| await execa('git', ['config', 'user.name', 'Yoshi Automation']); |
There was a problem hiding this comment.
@sofisl just checking this is our most up to date git username and email
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Towards internal b/309836530