fix: Set initial map padding (#326) #327
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kkris
force-pushed
the
set-initial-map-padding
branch
from
b3030b1
to
ae012d1
Compare
|
Thanks for the contribution @kkris ! This fixes the issue. |
kikoso
approved these changes
Oct 13, 2023
|
@kikoso Thanks for reviewing! Any idea how to fix the |
|
Hi @kkris ! Since you are running it from another branch, the instrumented tests are going to fail since you do not have a local API Key. We have thought of a couple of solutions here, but nothing in place so far. What you can do in the meantime is run the instrumentation test locally. Before merging the external contributions we run the test locally too. |
bubenheimer
suggested changes
Feb 2, 2024
maps-compose/src/main/java/com/google/maps/android/compose/MapUpdater.kt
Outdated
Show resolved
Hide resolved
bubenheimer
reviewed
Feb 3, 2024
maps-compose/src/main/java/com/google/maps/android/compose/MapUpdater.kt
Outdated
Show resolved
Hide resolved
kkris
force-pushed
the
set-initial-map-padding
branch
from
2e1422e
to
ba8719d
Compare
|
I rebased the branch on current main and applied the review comments. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #326 🦕
With this fix applied, the example from #326 now behaves correctly: https://github.com/googlemaps/android-maps-compose/assets/232214/7a07bcbb-c9fc-4924-8131-762926f36e29