Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: added lint report #1406

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

chore: added lint report #1406

wants to merge 8 commits into from

Conversation

kikoso
Copy link
Collaborator

@kikoso kikoso commented Oct 15, 2024

This PR uploads the SARIF Lint file to get the warnings reported.

@googlemaps-bot
Copy link
Contributor

googlemaps-bot commented Oct 15, 2024 •
edited
Loading

Code Coverage

Overall Project 38.14% 🍏
File Coverage
KmlLayer.java 0% 🍏
DefaultClusterRenderer.java 0% 🍏
MarkerManager.java 0% 🍏

@github-advanced-security
Copy link

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

@kikoso kikoso marked this pull request as ready for review October 16, 2024 08:32
@kikoso kikoso requested a review from a team as a code owner October 16, 2024 08:32
@kikoso kikoso requested a review from willum070 October 16, 2024 08:32
github-advanced-security[bot]
github-advanced-security bot found potential problems Oct 16, 2024
View reviewed changes
demo/src/main/res/layout/places_demo.xml
@@ -43,10 +45,11 @@
android:layout_width="wrap_content"
android:layout_height="match_parent"
android:text="Go"
android:onClick="submit"/>
android:onClick="submit"

Check warning

Code scanning / Android Lint

Using android:onClick on older version of the platform is broken Warning

Use databinding or explicit wiring of click listener in code
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@willum070 willum070 Awaiting requested review from willum070 willum070 is a code owner automatically assigned from googlemaps/admin

At least 1 approving review is required to merge this pull request.

Assignees

@dkhawk dkhawk

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kikoso @googlemaps-bot @dkhawk