fix: handle zero as a valid value for marker position #892
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use null check to prevent 0 value to be falsy.
Also, the code
new google.maps.LatLng(null);
return a marker with the coordiate (NaN, 0) and it break the SuperCluster algorithm.Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #891 🦕