Fix panic on startup #772
Merged
Fix panic on startup #772
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
any updates? I need this fix :( |
|
cc @zhenghaoz |
Cao Cao @just in |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #772 +/- ##
==========================================
- Coverage 70.07% 70.06% -0.02%
==========================================
Files 66 66
Lines 12544 12546 +2
==========================================
Hits 8790 8790
- Misses 2940 2941 +1
- Partials 814 815 +1
☔ View full report in Codecov by Sentry. |
|
Thank you for your fix |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull fixes an index out-of-bounds error on startup. Under the right conditions this occurs every time.
Repro data available if needed.
Related to #585