fix: download relative artifact URLs against the API base - #11
Merged
Conversation
The sync response's relative artifact path is relative to the API base, but the download stripped the /api suffix before appending it, so the request hit the frontend SPA fallback and saved index.html as the artifact with exit 0. Unnoticed on GoRules cloud, which normally hands out absolute signed CDN URLs; any deployment taking the relative fallback (self-hosted without CDN) was affected. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
stefan-gorules
approved these changes
Aug 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The sync response's relative artifact path is relative to the API base, but the download stripped the /api suffix before appending it, so the request hit the frontend SPA fallback and saved index.html as the artifact with exit 0. Unnoticed on GoRules cloud, which normally hands out absolute signed CDN URLs; any deployment taking the relative fallback (self-hosted without CDN) was affected.