fix: avoid shell interpretation of --url when opening the browser - #7
Closed
ivanmiletic wants to merge 1 commit into
Closed
fix: avoid shell interpretation of --url when opening the browser#7ivanmiletic wants to merge 1 commit into
ivanmiletic wants to merge 1 commit into
Conversation
`exec` runs its argument through `sh -c`, so the server URL was parsed as shell before reaching the browser. Inside the double quotes, `$(...)` and backticks still expand, and a `"` closes the quote outright, letting a URL run arbitrary commands as the CLI user. Normally --url is typed by the operator, so there is nothing to gain. It matters when the value comes from somewhere else: a CI variable, a wrapper script, or a project config an integration builds the command from. execFile passes the URL as argv with no shell involved. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
ivanmiletic
force-pushed
the
fix/mcp-open-command-injection
branch
from
August 19, 2026 09:05
00a7934 to
d82a79a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
execruns its argument throughsh -c, so the server URL was parsed as shell before reaching the browser. Inside the double quotes,$(...)and backticks still expand, and a"closes the quote outright, letting a URL run arbitrary commands as the CLI user.Normally --url is typed by the operator, so there is nothing to gain. It matters when the value comes from somewhere else: a CI variable, a wrapper script, or a project config an integration builds the command from.
execFile passes the URL as argv with no shell involved.