-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix functional tests pt 2 #9713
Conversation
🪼 branch checks and previews
Install Gradio from this PR pip install https://gradio-pypi-previews.s3.amazonaws.com/f0f19a7b37065c2208b663c139fc7b1cd809b034/gradio-5.2.0-py3-none-any.whl Install Gradio Python Client from this PR pip install "gradio-client @ git+https://github.com/gradio-app/gradio@f0f19a7b37065c2208b663c139fc7b1cd809b034#subdirectory=client/python" Install Gradio JS Client from this PR npm install https://gradio-npm-previews.s3.amazonaws.com/f0f19a7b37065c2208b663c139fc7b1cd809b034/gradio-client-1.7.0.tgz Use Lite from this PR <script type="module" src="https://gradio-lite-previews.s3.amazonaws.com/f0f19a7b37065c2208b663c139fc7b1cd809b034/dist/lite.js""></script> |
🦄 no changes detectedThis Pull Request does not include changes to any packages.__No changes detected. __
|
@@ -57,7 +57,7 @@ test("Audio drag-and-drop displays a warning when the file is of the wrong mime | |||
"audio_sample.wav" | |||
); | |||
const toast = page.getByTestId("toast-body"); | |||
expect(toast).toContainText("warning"); | |||
expect(toast).toContainText("Warning"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The case changed in #9670
const change_text = page.locator("#change h2"); | ||
await expect(change_text).toContainText("1"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
split up the tests here because playwright was being weird. Coverage is the same now though.
@@ -10,13 +10,13 @@ test.beforeAll(() => { | |||
const demo = ` | |||
import gradio as gr | |||
def greet(msg, history): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The indentation was messed up
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm nice finds @freddyaboulton!
Thanks @abidlabs ! CI should hopefully be green again tomorrow! |
Description
#9681 broke some tests. Also taking a crack at the image editor tests
🎯 PRs Should Target Issues
Before your create a PR, please check to see if there is an existing issue for this change. If not, please create an issue before you create this PR, unless the fix is very small.
Not adhering to this guideline will result in the PR being closed.
Tests
PRs will only be merged if tests pass on CI. To run the tests locally, please set up your Gradio environment locally and run the tests:
bash scripts/run_all_tests.sh
You may need to run the linters:
bash scripts/format_backend.sh
andbash scripts/format_frontend.sh