Fix chatbot component streaming bug and visible bug #9730
Merged
+33
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🪼 branch checks and previews
Install Gradio from this PR pip install https://gradio-pypi-previews.s3.amazonaws.com/ded734af863bd4da29badae154373a2975820011/gradio-5.2.0-py3-none-any.whlInstall Gradio Python Client from this PR pip install "gradio-client @ git+https://github.com/gradio-app/gradio@ded734af863bd4da29badae154373a2975820011#subdirectory=client/python"Install Gradio JS Client from this PR npm install https://gradio-npm-previews.s3.amazonaws.com/ded734af863bd4da29badae154373a2975820011/gradio-client-1.7.0.tgzUse Lite from this PR <script type="module" src="https://gradio-lite-previews.s3.amazonaws.com/ded734af863bd4da29badae154373a2975820011/dist/lite.js""></script> |
🦄 change detectedThis Pull Request includes changes to the following packages.
With the following changelog entry.
Maintainers or the PR author can modify the PR title to modify this entry.
|
freddyaboulton
changed the title
freddyaboulton
requested review from
pngwn,
abidlabs,
aliabid94,
dawoodkhan82 and
hannahblair
and removed request for
pngwn
aliabid94
approved these changes
Oct 16, 2024
js/chatbot/Index.svelte
Outdated
| @@ -92,7 +92,7 @@ | |||
| {min_height} | |||
| {max_height} | |||
| allow_overflow={true} | |||
| flex={true} | |||
| flex={visible} | |||
There was a problem hiding this comment.
minor but feel like this should be fixed at the Block.svelte level - if flex=true, but visible=false, the Block should be hidden
gradio/components/chatbot.py
Outdated
| @@ -447,6 +448,9 @@ def _postprocess_content( | |||
| return chat_message | |||
| elif isinstance(chat_message, FileData): | |||
| return FileMessage(file=chat_message) | |||
| elif isinstance(chat_message, ComponentMessage): | |||
| # in the case where components are part of a streaming response | |||
There was a problem hiding this comment.
seems like self explanatory code,, comment is unnecessary imo
aliabid94
reviewed
Oct 16, 2024
Comment on lines
+600
to
+612
| .image-preview { | ||
| position: absolute; | ||
| z-index: 999; | ||
| left: 0; | ||
| top: 0; | ||
| width: 100%; | ||
| height: 100%; | ||
| overflow: auto; | ||
| background-color: var(--background-fill-secondary); | ||
| display: flex; | ||
| justify-content: center; | ||
| align-items: center; | ||
| } |
There was a problem hiding this comment.
why is this css necessary? seemed to work fine before
There was a problem hiding this comment.
This is only needed for the full-screen image preview. Otherwise when you click on an image to pull up the full screen view it will be messed up
|
Thank you @aliabid94 !! |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes #9366
Closes #9724
Also the image preview button styling was messed up. I aligned it with the other icon buttons.
🎯 PRs Should Target Issues
Before your create a PR, please check to see if there is an existing issue for this change. If not, please create an issue before you create this PR, unless the fix is very small.
Not adhering to this guideline will result in the PR being closed.
Tests
PRs will only be merged if tests pass on CI. To run the tests locally, please set up your Gradio environment locally and run the tests:
bash scripts/run_all_tests.shYou may need to run the linters:
bash scripts/format_backend.shandbash scripts/format_frontend.sh