Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix tag definition #175

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix tag definition #175

wants to merge 1 commit into from

Conversation

brakkio86
Copy link

I've fixed tag definition as they don't work as expected.
Thanks,
Francesco

@CLAassistant
Copy link

CLAassistant commented Apr 8, 2024 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

gardar
gardar reviewed Apr 9, 2024
View reviewed changes
Copy link
Collaborator

@gardar gardar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you elaborate? There are already tags being applied to the included tasks.

@brakkio86
Copy link
Author

The apply: -> tags: -> TAG_NAME is not the same as apply a tag in include task. In fact, for instance, calling ansible playbook with --tags grafana_install do nothing. With my change, it works as expected.

For more information, check official documentation here.

Thanks,
Francesco

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gardar gardar gardar left review comments

@ishanjainn ishanjainn Awaiting requested review from ishanjainn ishanjainn is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@brakkio86 @CLAassistant @gardar