Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

delete obsolete variable login_remember_days #176

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

delete obsolete variable login_remember_days #176

wants to merge 1 commit into from

Conversation

brakkio86
Copy link

I've removed obsolete variable login_remember_days as it is not referenced anywhere. Thanks, Francesco

@brakkio86
delete obsolete variable login_remember_days
b73f434 
Signed-off-by: Francesco Trentini <francesco.trentini@ris.bz.it>
@gardar
Copy link
Collaborator

gardar commented Apr 9, 2024

Thanks for the PR.
Has that setting been deprecated in grafana? Or are you suggesting that this should be removed since it's not referenced anywhere directly in the ansible role?

@brakkio86
Copy link
Author

Hello, the option is not documented here, therefore I think it is deprecated. Thanks, Francesco

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gardar gardar Awaiting requested review from gardar gardar is a code owner

@ishanjainn ishanjainn Awaiting requested review from ishanjainn ishanjainn is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@brakkio86 @gardar