-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(storage): AWS backend using thanos.io/objstore #11221
base: main
Are you sure you want to change the base?
Conversation
fd69ec7
to
4bc8466
Compare
Trivy scan found the following vulnerabilities:
|
b8f05d5
to
41982d2
Compare
674c73f
to
4c2859b
Compare
func (cfg *HTTPConfig) RegisterFlagsWithPrefix(prefix string, f *flag.FlagSet) { | ||
cfg.Config.RegisterFlagsWithPrefix(prefix+"s3.", f) | ||
} | ||
|
||
// Config holds the config options for an S3 backend | ||
type Config struct { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@JoaoBraveCoding would you be able to add STSEndpoint to this config?
the thanos store supports this and would add support for minio STS auth flow.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, no problem from my side. I'll do it once #11132 merges since it will likely be the first to go. Then I'll need to rebase this one and I'll add your request
e0cfa6e
to
4337f02
Compare
What this PR does / why we need it:
This PR adds support to use the thanos.io/objstore backend for the AWS provider for all components excluding the Ruler since it's similar to the work done in #11132.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
.http
while others weren't)CLI Table
Checklist
CONTRIBUTING.md
guide (required)CHANGELOG.md
updatedadd-to-release-notes
labeldocs/sources/setup/upgrade/_index.md
production/helm/loki/Chart.yaml
and updateproduction/helm/loki/CHANGELOG.md
andproduction/helm/loki/README.md
. Example PRdeprecated-config.yaml
anddeleted-config.yaml
files respectively in thetools/deprecated-config-checker
directory. Example PR