chore(querier): Ensure Plan is set in test QueryRequest/SampleQueryRequest - #24136
Open
chaudum wants to merge 1 commit into
Open
chore(querier): Ensure Plan is set in test QueryRequest/SampleQueryRequest#24136chaudum wants to merge 1 commit into
chaudum wants to merge 1 commit into
Conversation
…quest Add testutil.MustPlan() helper to create QueryPlan from selector strings and update all test files to use it instead of inline plan literals. This is step 1 of the QueryRequest.Selector to QueryRequest.Plan migration (loki-private#2709): ensuring Plan is always populated on every producer. Changes: - Add pkg/querier/testutil/requests.go with MustPlan() helper - Update 22 test files to use testutil.MustPlan() (115 instances) - 32 instances remain where AST uses pre-parsed expressions The fallback code in ingester and marshal layers remains for version-skew compatibility during rollout.
chaudum
marked this pull request as ready for review
August 21, 2026 15:26
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Add testutil.MustPlan() helper to create QueryPlan from selector strings and update all test files to use it instead of inline plan literals.
This is step 1 of the QueryRequest.Selector to QueryRequest.Plan migration: ensuring Plan is always populated on every producer.
Changes:
The fallback code in ingester and marshal layers remains for version-skew compatibility during rollout.